Add OpenAI's GPT-5.5 model#966
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (17)
📝 WalkthroughWalkthroughThis PR adds support for the OpenAI GPT-5.5 model across the application. It includes adding the new model to the configuration registry, extending i18n translations across 12 language locales, and updating relevant unit tests to cover the new model option. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
Review Summary by QodoAdd OpenAI's GPT-5.5 model support
WalkthroughsDescription• Add GPT-5.5 model support across all localization files • Register GPT-5.5 in model configuration and API keys • Update unit tests for GPT-5.5 model compatibility Diagramflowchart LR
A["GPT-5.5 Model"] --> B["Localization Files"]
A --> C["Config Index"]
A --> D["Unit Tests"]
B --> E["12 Language Files"]
C --> F["Model Keys & Definitions"]
D --> G["Token Params & Name Conversion"]
File Changes1. src/_locales/de/main.json
|
There was a problem hiding this comment.
Pull request overview
Adds GPT-5.5 as a selectable OpenAI API model across configuration, localization, and unit tests.
Changes:
- Register
chatgptApi5_5in the OpenAI API model key list andModelsmap (value: 'gpt-5.5',desc: 'OpenAI (GPT-5.5)'). - Extend unit tests to cover the new model for description mapping and token-parameter selection.
- Add the
OpenAI (GPT-5.5)i18n string across supported locales.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/utils/model-name-convert.test.mjs | Adds coverage that chatgptApi5_5 maps to the expected UI description. |
| tests/unit/services/apis/openai-token-params.test.mjs | Ensures gpt-5.5 uses max_completion_tokens for OpenAI chat completions. |
| tests/unit/config/config-predicates.test.mjs | Includes chatgptApi5_5 among representative OpenAI Chat Completions API model keys. |
| src/config/index.mjs | Adds chatgptApi5_5 to exported model keys and registers the model in Models. |
| src/_locales/en/main.json | Adds i18n entry for OpenAI (GPT-5.5). |
| src/_locales/de/main.json | Adds i18n entry for OpenAI (GPT-5.5). |
| src/_locales/es/main.json | Adds i18n entry for OpenAI (GPT-5.5). |
| src/_locales/fr/main.json | Adds i18n entry for OpenAI (GPT-5.5). |
| src/_locales/in/main.json | Adds i18n entry for OpenAI (GPT-5.5). |
| src/_locales/it/main.json | Adds i18n entry for OpenAI (GPT-5.5). |
| src/_locales/ja/main.json | Adds i18n entry for OpenAI (GPT-5.5). |
| src/_locales/ko/main.json | Adds i18n entry for OpenAI (GPT-5.5). |
| src/_locales/pt/main.json | Adds i18n entry for OpenAI (GPT-5.5). |
| src/_locales/ru/main.json | Adds i18n entry for OpenAI (GPT-5.5). |
| src/_locales/tr/main.json | Adds i18n entry for OpenAI (GPT-5.5). |
| src/_locales/zh-hans/main.json | Adds i18n entry for OpenAI (GPT-5.5). |
| src/_locales/zh-hant/main.json | Adds i18n entry for OpenAI (GPT-5.5). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request adds support for the OpenAI GPT-5.5 model by updating localization files, configuration constants, and unit tests. The reviewer suggested adding a 'latest' alias for the new model to maintain consistency with previous 5.x releases and recommended including GPT-5.4 in the token parameters test suite to improve overall coverage.
| 'chatgptApi5_4', | ||
| 'chatgptApi5_4Mini', | ||
| 'chatgptApi5_4Nano', | ||
| 'chatgptApi5_5', |
There was a problem hiding this comment.
The addition of chatgptApi5_5 is consistent with the existing 5.x model group. However, following the established pattern for major/minor releases (like 5.0, 5.1, 5.2, and 5.3), a corresponding chatgptApi5_5Latest entry is missing. If OpenAI provides a -chat-latest alias for this version, it should be included here and in the Models object.
| 'gpt-5.3-chat-latest', | ||
| 'gpt-5.4-mini', | ||
| 'gpt-5.4-nano', | ||
| 'gpt-5.5', |
There was a problem hiding this comment.
The addition of gpt-5.5 to the test suite is correct. However, I noticed that gpt-5.4 is missing from this list of models that should use max_completion_tokens, even though it is defined in the configuration. While not strictly part of this PR's objective, adding it would improve test coverage for the 5.x series.
'gpt-5.4',
'gpt-5.4-mini',
'gpt-5.4-nano',
'gpt-5.5',
Refs:
Summary by CodeRabbit